Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swipe to reply activated too early #3034

Merged
merged 2 commits into from
May 24, 2024

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Swipe to reply is being activated INSTANTLY, as soon as the gesture starts.

Causes

We upgraded to an alpha05 version of the compose foundation.

Solutions

The issue was fixed on alpha08. I upgraded to beta01 (one release after the fix, but more stable).
The lib also had a few breaking changes I had to address:

  • TextFieldCharSequence was made internal, and selection was taken out of it, exposed in TextFieldState
  • BasicTextField doesn't take keyboardActions anymore, but rather a KeyboardActionHandler, and it can be removed to keep the default bahaviour. I couldn't find usages for this in our codebase, so I just removed the parameter.

Testing

Manually tested.


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods requested review from saleniuk, a team, typfel, yamilmedina, mchenani and ohassine and removed request for a team May 24, 2024 10:55
Copy link
Contributor

github-actions bot commented May 24, 2024

Test Results

928 tests   928 ✅  11m 54s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit 82be5b3.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 4980 failed.

@vitorhugods vitorhugods force-pushed the fix/swipe-to-reply-activated-too-early branch from c749c9b to 82be5b3 Compare May 24, 2024 11:09
@vitorhugods vitorhugods enabled auto-merge (squash) May 24, 2024 11:10
Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vitorhugods vitorhugods merged commit b06b525 into release/candidate May 24, 2024
12 of 13 checks passed
@vitorhugods vitorhugods deleted the fix/swipe-to-reply-activated-too-early branch May 24, 2024 12:15
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4985 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants